Public backoff directory #1893
Open
Public backoff directory #1893
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pipiland2612 <[email protected]>
pipiland2612
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
bwplotka
requested changes
Oct 12, 2025
There was a problem hiding this comment.
Thanks, but this is not an acceptable solution, there's a reason why YOLO vendored code is internal. Have you thought about 3 options we talked about and their pros and cons?
We need to decide:
- Make github.com/efficientgo/core/backoff a direct dependency
- Copy backoff.Config
3.Use some other backoff config parameters
This PR looks like a hidden (1) option and it has some negative consequences. Can you tell what could be those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose backoff directory so that we could use the function
client_golang/exp/api/remote/remote_api.go
Line 111 in c5900a1